can: usb_8dev: do not report txerr and rxerr during bus-off
authorVincent Mailhol <mailhol.vincent@wanadoo.fr>
Tue, 19 Jul 2022 14:35:47 +0000 (23:35 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:11:19 +0000 (11:11 +0200)
[ Upstream commit aebe8a2433cd090ccdc222861f44bddb75eb01de ]

During bus off, the error count is greater than 255 and can not fit in
a u8.

Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices")
Link: https://lore.kernel.org/all/20220719143550.3681-10-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/usb/usb_8dev.c

index 232f45f722f0c7e405ffeef27bb0afeafd95564d..5cb5be4dc941f328d8d2338fbcedf855e54103cb 100644 (file)
@@ -453,9 +453,10 @@ static void usb_8dev_rx_err_msg(struct usb_8dev_priv *priv,
 
        if (rx_errors)
                stats->rx_errors++;
-
-       cf->data[6] = txerr;
-       cf->data[7] = rxerr;
+       if (priv->can.state != CAN_STATE_BUS_OFF) {
+               cf->data[6] = txerr;
+               cf->data[7] = rxerr;
+       }
 
        priv->bec.txerr = txerr;
        priv->bec.rxerr = rxerr;