PM / QoS: Fix default runtime_pm device resume latency
authorTero Kristo <t-kristo@ti.com>
Mon, 30 Oct 2017 07:10:46 +0000 (09:10 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 30 Oct 2017 09:54:57 +0000 (10:54 +0100)
The recent change to the PM QoS framework to introduce a proper
no constraint value overlooked to handle the devices which don't
implement PM QoS OPS.  Runtime PM is one of the more severely
impacted subsystems, failing every attempt to runtime suspend
a device.  This leads into some nasty second level issues like
probe failures and increased power consumption among other
things.

Fix this by adding a proper return value for devices that don't
implement PM QoS.

Fixes: 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
include/linux/pm_qos.h

index 6737a8c9e8c694c8bbf2e04d67de4da6b961d3e6..d68b0569a5ebe65e7562ae0e733ec25281765e82 100644 (file)
@@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_flags(struct device *dev)
 static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
 {
        return IS_ERR_OR_NULL(dev->power.qos) ?
-               0 : pm_qos_read_value(&dev->power.qos->resume_latency);
+               PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
+               pm_qos_read_value(&dev->power.qos->resume_latency);
 }
 #else
 static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,