iwlwifi: improve oversized command warning
authorJohannes Berg <johannes.berg@intel.com>
Wed, 26 Sep 2012 11:32:13 +0000 (13:32 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 16 Oct 2012 14:30:15 +0000 (16:30 +0200)
When warning about a command that is too large,
print out the command name/ID to help figure
out which place is attempting to send a command
that is too large.

Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/iwlwifi/pcie/tx.c

index 105e3af3c621b0b9e335fbe42d1ea1e444bfa579..b50d1b4a4fcf98d4ef600ed93836494e42ed1536 100644 (file)
@@ -549,7 +549,10 @@ static int iwl_enqueue_hcmd(struct iwl_trans *trans, struct iwl_host_cmd *cmd)
         * allocated into separate TFDs, then we will need to
         * increase the size of the buffers.
         */
-       if (WARN_ON(copy_size > TFD_MAX_PAYLOAD_SIZE))
+       if (WARN(copy_size > TFD_MAX_PAYLOAD_SIZE,
+                "Command %s (%#x) is too large (%d bytes)\n",
+                trans_pcie_get_cmd_string(trans_pcie, cmd->id),
+                cmd->id, copy_size))
                return -EINVAL;
 
        spin_lock_bh(&txq->lock);