net: can: usb: gs_usb: don't print error when allocating urb fails
authorWolfram Sang <wsa-dev@sang-engineering.com>
Thu, 11 Aug 2016 21:05:22 +0000 (23:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Aug 2016 21:53:39 +0000 (14:53 -0700)
kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/usb/gs_usb.c

index 6f0cbc38782e68ac41275c89ea5cea1e534cf35e..77e3cc06a30c8cb970b6afef41352a15716c9331 100644 (file)
@@ -493,10 +493,8 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,
 
        /* create a URB, and a buffer for it */
        urb = usb_alloc_urb(0, GFP_ATOMIC);
-       if (!urb) {
-               netdev_err(netdev, "No memory left for URB\n");
+       if (!urb)
                goto nomem_urb;
-       }
 
        hf = usb_alloc_coherent(dev->udev, sizeof(*hf), GFP_ATOMIC,
                                &urb->transfer_dma);
@@ -600,11 +598,8 @@ static int gs_can_open(struct net_device *netdev)
 
                        /* alloc rx urb */
                        urb = usb_alloc_urb(0, GFP_KERNEL);
-                       if (!urb) {
-                               netdev_err(netdev,
-                                          "No memory left for URB\n");
+                       if (!urb)
                                return -ENOMEM;
-                       }
 
                        /* alloc rx buffer */
                        buf = usb_alloc_coherent(dev->udev,