drm/dp_helper: Print first error received on failure in drm_dp_dpcd_access()
authorLyude <cpaul@redhat.com>
Sat, 6 Aug 2016 00:30:33 +0000 (20:30 -0400)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 9 Aug 2016 16:23:44 +0000 (18:23 +0200)
Since we always retry in drm_dp_dpcd_access() regardless of the error,
we're going to make a lot of noise if the aux->transfer function prints
it's own errors (as is the case with radeon). If we can print the error
code here, this reduces the need for drivers to do this. So instead of
having to print "dp_aux_ch timed out" over 32 times we can just print
once.

Signed-off-by: Lyude <cpaul@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1470443443-27252-2-git-send-email-cpaul@redhat.com
drivers/gpu/drm/drm_dp_helper.c

index eae5ef963cb790d261a5093aa8b8d72671b25e86..198e9e22f72b40eb7c52f83f0906faed4d295bea 100644 (file)
@@ -223,7 +223,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
                        err = ret;
        }
 
-       DRM_DEBUG_KMS("too many retries, giving up\n");
+       DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err);
        ret = err;
 
 unlock: