ehea: fix operation state report
authorGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Thu, 3 Nov 2016 10:16:20 +0000 (08:16 -0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Nov 2016 20:25:37 +0000 (16:25 -0400)
Currently the ehea driver is missing a call to netif_carrier_off()
before the interface bring-up; this is necessary in order to
initialize the __LINK_STATE_NOCARRIER bit in the net_device state
field. Otherwise, we observe state UNKNOWN on "ip address" command
output.

This patch adds a call to netif_carrier_off() on ehea's net device
open callback.

Reported-by: Xiong Zhou <zhou@redhat.com>
Reference-ID: IBM bz #137702, Red Hat bz #1089134
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ehea/ehea_main.c

index 54efa9a5167b86021802b98900e6ff216fa10a73..bd719e25dd76d75395711b87d792fb28ca6dd692 100644 (file)
@@ -2446,6 +2446,8 @@ static int ehea_open(struct net_device *dev)
 
        netif_info(port, ifup, dev, "enabling port\n");
 
+       netif_carrier_off(dev);
+
        ret = ehea_up(dev);
        if (!ret) {
                port_napi_enable(port);