Revert "USB: quatech2: only write to the tty if the port is open."
authorBill Pemberton <wfp5p@virginia.edu>
Wed, 20 Mar 2013 15:46:10 +0000 (11:46 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 23:27:55 +0000 (16:27 -0700)
This reverts commit 27b351c5546008c640b3e65152f60ca74b3706f1.

Calling tty_flip_buffer_push on an unopened tty is legal, so the
driver doesn't need track if port has been opened.  Reverting this
allows the entire is_open logic to be removed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/quatech2.c

index d643a4d4d770819a68cd32f9402b5d2e8839c436..00e6c9bac8a309b0df675903654ce0521f991cad 100644 (file)
@@ -661,9 +661,7 @@ void qt2_process_read_urb(struct urb *urb)
                                                 __func__);
                                        break;
                                }
-
-                               if (port_priv->is_open)
-                                       tty_flip_buffer_push(&port->port);
+                               tty_flip_buffer_push(&port->port);
 
                                newport = *(ch + 3);
 
@@ -706,8 +704,7 @@ void qt2_process_read_urb(struct urb *urb)
                tty_insert_flip_string(&port->port, ch, 1);
        }
 
-       if (port_priv->is_open)
-               tty_flip_buffer_push(&port->port);
+       tty_flip_buffer_push(&port->port);
 }
 
 static void qt2_write_bulk_callback(struct urb *urb)