RDMA/cxgb4: Remove db_drop_task
authorSteve Wise <swise@opengridcomputing.com>
Fri, 11 Mar 2011 22:30:32 +0000 (22:30 +0000)
committerRoland Dreier <roland@purestorage.com>
Mon, 14 Mar 2011 19:09:10 +0000 (12:09 -0700)
Unloading iw_cxgb4 can crash due to the unload code trying to use
db_drop_task, which is uninitialized.  So remove this dead code.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/cxgb4/device.c
drivers/infiniband/hw/cxgb4/iw_cxgb4.h

index 54fbc1118abe0eb2e2e4592ab0724e1e72ca0f5a..1a65ee6235bfb891ead73ff13e70f62bfaa2f5be 100644 (file)
@@ -368,7 +368,6 @@ static void c4iw_rdev_close(struct c4iw_rdev *rdev)
 static void c4iw_remove(struct c4iw_dev *dev)
 {
        PDBG("%s c4iw_dev %p\n", __func__,  dev);
-       cancel_delayed_work_sync(&dev->db_drop_task);
        list_del(&dev->entry);
        if (dev->registered)
                c4iw_unregister_device(dev);
index 2fe19ec9ba6012f3e10d6ff6fe6219ac8cc5b682..9f6166f59268e8a597e7a8ea5a958184b217afc7 100644 (file)
@@ -176,7 +176,6 @@ struct c4iw_dev {
        struct idr mmidr;
        spinlock_t lock;
        struct list_head entry;
-       struct delayed_work db_drop_task;
        struct dentry *debugfs_root;
        u8 registered;
 };