HID: cp2112: remove various hid_out_raw_report calls
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Sun, 9 Mar 2014 03:52:40 +0000 (22:52 -0500)
committerJiri Kosina <jkosina@suse.cz>
Fri, 14 Mar 2014 14:29:53 +0000 (15:29 +0100)
hid_out_raw_report is going to be obsoleted as it is not part of the
unified HID low level transport documentation
(Documentation/hid/hid-transport.txt)

  hid_output_raw_report(hdev, buf, sizeof(buf), HID_FEATURE_REPORT);
is strictly equivalent to:
  hid_hw_raw_request(hdev, buf[0], buf, sizeof(buf),
HID_FEATURE_REPORT, HID_REQ_SET_REPORT);

Then replace buf[0] by the appropriate define.

So use the new api.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-cp2112.c

index 1025982c7fd3c53953f725bbc4a5e15eae17e32f..3913eb9fec2aad6d87cc79ff7c752b13d9420d10 100644 (file)
@@ -185,8 +185,8 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
        buf[1] &= ~(1 << offset);
        buf[2] = gpio_push_pull;
 
-       ret = hdev->hid_output_raw_report(hdev, buf, sizeof(buf),
-                                         HID_FEATURE_REPORT);
+       ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf, sizeof(buf),
+                                HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
        if (ret < 0) {
                hid_err(hdev, "error setting GPIO config: %d\n", ret);
                return ret;
@@ -207,8 +207,8 @@ static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
        buf[1] = value ? 0xff : 0;
        buf[2] = 1 << offset;
 
-       ret = hdev->hid_output_raw_report(hdev, buf, sizeof(buf),
-                                         HID_FEATURE_REPORT);
+       ret = hid_hw_raw_request(hdev, CP2112_GPIO_SET, buf, sizeof(buf),
+                                HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
        if (ret < 0)
                hid_err(hdev, "error setting GPIO values: %d\n", ret);
 }
@@ -253,8 +253,8 @@ static int cp2112_gpio_direction_output(struct gpio_chip *chip,
        buf[1] |= 1 << offset;
        buf[2] = gpio_push_pull;
 
-       ret = hdev->hid_output_raw_report(hdev, buf, sizeof(buf),
-                                         HID_FEATURE_REPORT);
+       ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf, sizeof(buf),
+                                HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
        if (ret < 0) {
                hid_err(hdev, "error setting GPIO config: %d\n", ret);
                return ret;