pinctrl: coh901: Fix error checking in u300_gpio_to_irq

The pointer "port" is always not NULL if gpio->port_list is not empty.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/pinctrl-coh901.c b/drivers/pinctrl/pinctrl-coh901.c
index 86887850ac13431b296bd8d09d83e5be68ffc6a5..edde3acc41864b5d9770be7696e553558d428902 100644 (file)
--- a/drivers/pinctrl/pinctrl-coh901.c
+++ b/drivers/pinctrl/pinctrl-coh901.c
@@ -318,13 +318,16 @@ static int u300_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
        struct u300_gpio_port *port = NULL;
        struct list_head *p;
        int retirq;
+       bool found = false;
 
        list_for_each(p, &gpio->port_list) {
                port = list_entry(p, struct u300_gpio_port, node);
-               if (port->number == portno)
+               if (port->number == portno) {
+                       found = true;
                        break;
+               }
        }
-       if (port == NULL) {
+       if (!found) {
                dev_err(gpio->dev, "could not locate port for GPIO %d IRQ\n",
                        offset);
                return -EINVAL;