tipc: Eliminate useless return value when disabling a bearer
authorAllan Stephens <Allan.Stephens@windriver.com>
Tue, 30 Nov 2010 12:00:56 +0000 (12:00 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Dec 2010 21:34:03 +0000 (13:34 -0800)
Modifies bearer_disable() to return void since it always indicates
success anyway.

Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/bearer.c

index 347f255b0de2e876d2860a9587195a1104a49297..885da94be4ac2361c1eaa60493164eb882928c03 100644 (file)
@@ -622,7 +622,7 @@ int tipc_block_bearer(const char *name)
  * Note: This routine assumes caller holds tipc_net_lock.
  */
 
-static int bearer_disable(struct bearer *b_ptr)
+static void bearer_disable(struct bearer *b_ptr)
 {
        struct link *l_ptr;
        struct link *temp_l_ptr;
@@ -638,7 +638,6 @@ static int bearer_disable(struct bearer *b_ptr)
        }
        spin_unlock_bh(&b_ptr->publ.lock);
        memset(b_ptr, 0, sizeof(struct bearer));
-       return 0;
 }
 
 int tipc_disable_bearer(const char *name)
@@ -651,8 +650,10 @@ int tipc_disable_bearer(const char *name)
        if (b_ptr == NULL) {
                warn("Attempt to disable unknown bearer <%s>\n", name);
                res = -EINVAL;
-       } else
-               res = bearer_disable(b_ptr);
+       } else {
+               bearer_disable(b_ptr);
+               res = 0;
+       }
        write_unlock_bh(&tipc_net_lock);
        return res;
 }