bridge: fix accidental creation of sysfs directory
authorStephen Hemminger <shemminger@vyatta.com>
Mon, 18 Apr 2011 00:52:51 +0000 (17:52 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 18 Apr 2011 00:52:51 +0000 (17:52 -0700)
Commit bb900b27a2f49b37bc38c08e656ea13048fee13b ("bridge: allow
creating bridge devices with netlink") introduced a bug in net-next
because of a typo in notifier. Every device would have the sysfs
bridge directory (and files).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_notify.c

index 7a03bb975375d295b8552d88e45a9b17e089ff46..606b323e8a0c52d3297707331a67b0b4a8a82316 100644 (file)
@@ -37,7 +37,7 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v
        int err;
 
        /* register of bridge completed, add sysfs entries */
-       if ((dev->priv_flags && IFF_EBRIDGE) && event == NETDEV_REGISTER) {
+       if ((dev->priv_flags & IFF_EBRIDGE) && event == NETDEV_REGISTER) {
                br_sysfs_addbr(dev);
                return NOTIFY_DONE;
        }