PCI: mvebu: Drop writes to bridge Secondary Status register
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tue, 26 Nov 2013 18:02:52 +0000 (11:02 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 26 Nov 2013 18:12:49 +0000 (11:12 -0700)
There are no writable bits in the secondary status register, only RO and
RW1C (write-1-to-clear) bits.  The driver never sets any of the RW1C bits,
so the status register should always be 0, just remove the set from the
write path.

Someday the RW1C bits should be copied/cleared directly from registers in
the HW.

[bhelgaas: changelog tweaks]
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
drivers/pci/host/pci-mvebu.c

index c269e430c760a9bc80ad982db9cb4aa211f16f45..6f5a20f3cdf62a2ca28e57e2cd519fbe59ab514b 100644 (file)
@@ -500,7 +500,6 @@ static int mvebu_sw_pci_bridge_write(struct mvebu_pcie_port *port,
                 */
                bridge->iobase = (value & 0xff) | PCI_IO_RANGE_TYPE_32;
                bridge->iolimit = ((value >> 8) & 0xff) | PCI_IO_RANGE_TYPE_32;
-               bridge->secondary_status = value >> 16;
                mvebu_pcie_handle_iobase_change(port);
                break;