ext2: Add alignment check for DAX mount

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Call bdev_dax_supported() to perform proper precondition checks
which includes this partition alignment check.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Boaz Harrosh <boaz@plexistor.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index b78caf25f746220ce635a3bd946bedeaf7e3e750..1d9379568aa833b1fdd48a8ff112d343e3a7f773 100644 (file)
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -922,16 +922,9 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
        blocksize = BLOCK_SIZE << le32_to_cpu(sbi->s_es->s_log_block_size);
 
        if (sbi->s_mount_opt & EXT2_MOUNT_DAX) {
-               if (blocksize != PAGE_SIZE) {
-                       ext2_msg(sb, KERN_ERR,
-                                       "error: unsupported blocksize for dax");
+               err = bdev_dax_supported(sb, blocksize);
+               if (err)
                        goto failed_mount;
-               }
-               if (!sb->s_bdev->bd_disk->fops->direct_access) {
-                       ext2_msg(sb, KERN_ERR,
-                                       "error: device does not support dax");
-                       goto failed_mount;
-               }
        }
 
        /* If the blocksize doesn't match, re-read the thing.. */