[media] ngene: better comment unused code to avoid warnings
authorMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 27 Oct 2012 19:17:39 +0000 (16:17 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 28 Oct 2012 09:38:46 +0000 (07:38 -0200)
get rid of a few warnings about empty body:
drivers/media/pci/ngene/ngene-core.c:756:3: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
drivers/media/pci/ngene/ngene-cards.c:429:5: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
Those are due to some commented code.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/ngene/ngene-cards.c
drivers/media/pci/ngene/ngene-core.c

index 96a13ed197d0856389a1bd9f7cbde4ca895dfbd8..b38bce529566cdaa02b87b2855674ba5a03dd90e 100644 (file)
@@ -425,8 +425,10 @@ static int ReadEEProm(struct i2c_adapter *adapter,
                status = i2c_read_eeprom(adapter, 0x50, Addr, data, Length);
                if (!status) {
                        *pLength = EETag[2];
+#if 0
                        if (Length < EETag[2])
-                               ; /*status=STATUS_BUFFER_OVERFLOW; */
+                               status = STATUS_BUFFER_OVERFLOW;
+#endif
                }
        }
        return status;
index c8e0d5b99d4c0d106bd02078ab1b678176d57b0d..2c2df88b4a9cafa5f11123a67f45a3441903357d 100644 (file)
@@ -752,8 +752,8 @@ void set_transfer(struct ngene_channel *chan, int state)
                if (chan->mode & NGENE_IO_TSIN)
                        chan->pBufferExchange = tsin_exchange;
                spin_unlock_irq(&chan->state_lock);
-       } else
-               ;/* printk(KERN_INFO DEVICE_NAME ": lock=%08x\n",
+       }
+               /* else printk(KERN_INFO DEVICE_NAME ": lock=%08x\n",
                           ngreadl(0x9310)); */
 
        ret = ngene_command_stream_control(dev, chan->number,