mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg
authorJack Wang <jinpu.wang@ionos.com>
Fri, 26 Aug 2022 10:13:35 +0000 (12:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:17:07 +0000 (13:17 +0200)
[ Upstream commit 6b207ce8a96a71e966831e3a13c38143ba9a73c1 ]

dma_map_sg return 0 on error, fix the error check, and return -EIO
to caller.

Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager")
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mailbox/bcm-flexrm-mailbox.c

index 7e3ed271463020b7ccb87ba08043c8941c462639..6e5d59f40a18b324e0709f4774de42e7c44124f1 100644 (file)
@@ -626,15 +626,15 @@ static int flexrm_spu_dma_map(struct device *dev, struct brcm_message *msg)
 
        rc = dma_map_sg(dev, msg->spu.src, sg_nents(msg->spu.src),
                        DMA_TO_DEVICE);
-       if (rc < 0)
-               return rc;
+       if (!rc)
+               return -EIO;
 
        rc = dma_map_sg(dev, msg->spu.dst, sg_nents(msg->spu.dst),
                        DMA_FROM_DEVICE);
-       if (rc < 0) {
+       if (!rc) {
                dma_unmap_sg(dev, msg->spu.src, sg_nents(msg->spu.src),
                             DMA_TO_DEVICE);
-               return rc;
+               return -EIO;
        }
 
        return 0;