[PATCH] DMI: only ioremap stuff we actually need
authorBjorn Helgaas <bjorn.helgaas@hp.com>
Sun, 26 Mar 2006 09:37:07 +0000 (01:37 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 26 Mar 2006 16:56:54 +0000 (08:56 -0800)
dmi_scan_machine() tries to ioremap 0x10000 (64K) bytes, even though it only
looks at the first 32 bytes or so.  If the SMBIOS table is near the end of a
memory region, the ioremap() may fail when it shouldn't.

This is in the efi_enabled path, so it really only affects ia64 at the moment.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Matt Domsch <Matt_Domsch@dell.com>
Cc: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>
Cc: Andi Kleen <ak@muc.de>
Acked-by: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/i386/kernel/dmi_scan.c

index bfecbd46f22a171d558431b2396db458162c20b8..c032f9e06bb61ebb362b144fe30a2de757524c56 100644 (file)
@@ -224,7 +224,7 @@ void __init dmi_scan_machine(void)
                 * needed during early boot.  This also means we can
                 * iounmap the space when we're done with it.
                */
-               p = dmi_ioremap((unsigned long)efi.smbios, 0x10000);
+               p = dmi_ioremap((unsigned long)efi.smbios, 32);
                if (p == NULL)
                        goto out;