wan: lmc: fix error return code
authorJulia Lawall <julia.lawall@lip6.fr>
Sun, 5 Apr 2015 12:06:21 +0000 (14:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Apr 2015 19:21:54 +0000 (15:21 -0400)
Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/lmc/lmc_main.c

index bea0f313a7a80cbd7528795ff04e67162f77f347..317bc79cc8b9b22eace33116de7504c216b60a39 100644 (file)
@@ -850,6 +850,7 @@ static int lmc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        dev = alloc_hdlcdev(sc);
        if (!dev) {
                printk(KERN_ERR "lmc:alloc_netdev for device failed\n");
+               err = -ENOMEM;
                goto err_hdlcdev;
        }