drm/rockchip: inno_hdmi: fix an error code
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Feb 2016 21:30:29 +0000 (00:30 +0300)
committerMark Yao <mark.yao@rock-chips.com>
Tue, 3 May 2016 06:11:22 +0000 (14:11 +0800)
We were accidentally returning PTR_ERR(NULL) which means success when we
wanted to return a negative error code.

Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Yakir Yang <ykk@rock-chips.com>
drivers/gpu/drm/rockchip/inno_hdmi.c

index 10d62fff22f1b9e6103694d53af924371e2eec6a..f2524419962683890c9f5d9d26179e83cd85f4fa 100644 (file)
@@ -855,8 +855,9 @@ static int inno_hdmi_bind(struct device *dev, struct device *master,
 
        hdmi->ddc = inno_hdmi_i2c_adapter(hdmi);
        if (IS_ERR(hdmi->ddc)) {
+               ret = PTR_ERR(hdmi->ddc);
                hdmi->ddc = NULL;
-               return PTR_ERR(hdmi->ddc);
+               return ret;
        }
 
        /*