rtc: at91sam9: use standard readl/writel functions instead of raw versions
authorBoris BREZILLON <boris.brezillon@free-electrons.com>
Tue, 23 Sep 2014 11:13:52 +0000 (13:13 +0200)
committerNicolas Ferre <nicolas.ferre@atmel.com>
Thu, 13 Nov 2014 15:07:58 +0000 (16:07 +0100)
Raw versions of writel and writel should not be directly used and should
be replaced by their relaxed versions (readl/writel_relaxed), which take
endianness conversion into account.

In this driver we prefer the standard readl/writel function which add the
appropriate memory barrier around the access (the performance penalty is
negligible for this kind of application).

Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Johan Hovold <johan@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
drivers/rtc/rtc-at91sam9.c

index 51f0038949dfaf275759e83fa9664c3ddc74a52a..74a9ca0bbeb4f2539b77072613c25d12c41e0deb 100644 (file)
@@ -77,14 +77,14 @@ struct sam9_rtc {
 };
 
 #define rtt_readl(rtc, field) \
-       __raw_readl((rtc)->rtt + AT91_RTT_ ## field)
+       readl((rtc)->rtt + AT91_RTT_ ## field)
 #define rtt_writel(rtc, field, val) \
-       __raw_writel((val), (rtc)->rtt + AT91_RTT_ ## field)
+       writel((val), (rtc)->rtt + AT91_RTT_ ## field)
 
 #define gpbr_readl(rtc) \
-       __raw_readl((rtc)->gpbr)
+       readl((rtc)->gpbr)
 #define gpbr_writel(rtc, val) \
-       __raw_writel((val), (rtc)->gpbr)
+       writel((val), (rtc)->gpbr)
 
 /*
  * Read current time and date in RTC