fpga: altera-hps2fpga: add NULL check on of_match_device() return value
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 2 Aug 2017 02:20:53 +0000 (21:20 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Aug 2017 21:27:55 +0000 (14:27 -0700)
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.

In case of NULL print error message and return -ENODEV

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/altera-hps2fpga.c

index a18ff430c9af13fba5cb79c56f5a38a152073680..e6c948b31474392866554d1b3efe87c1c72ed037 100644 (file)
@@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
        int ret;
 
        of_id = of_match_device(altera_fpga_of_match, dev);
+       if (!of_id) {
+               dev_err(dev, "failed to match device\n");
+               return -ENODEV;
+       }
+
        priv = (struct altera_hps2fpga_data *)of_id->data;
 
        priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,