staging: rtl8192e: make return of 0 explicit
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 19 May 2014 04:31:12 +0000 (06:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 May 2014 17:14:30 +0000 (02:14 +0900)
Delete unnecessary use of a local variable to immediately return 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c

index 356d5217e9d426ab235012263d10f23ad5d41d0e..2920e406030a8fd332a2636c36682a6f52a09284 100644 (file)
@@ -1915,8 +1915,7 @@ int rtl8192_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
        memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
        if (queue_index == TXCMD_QUEUE) {
                rtl8192_tx_cmd(dev, skb);
-               ret = 0;
-               return ret;
+               return 0;
        } else {
                tcb_desc->RATRIndex = 7;
                tcb_desc->bTxDisableRateFallBack = 1;