mlx5: remove unnecessary pci_set_drvdata()
authorZhu Yanjun <yanjun.zhu@oracle.com>
Tue, 15 Aug 2017 06:33:06 +0000 (02:33 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Aug 2017 23:46:48 +0000 (16:46 -0700)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not necessary to manually clear the
device driver data to NULL.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/main.c

index 6dbd637b4e665f45d3e7b515363bc532752448ab..7e6e2439892642ead213244a53ceba6c05a587ab 100644 (file)
@@ -1400,7 +1400,6 @@ clean_srcu:
        cleanup_srcu_struct(&priv->pfault_srcu);
 clean_dev:
 #endif
-       pci_set_drvdata(pdev, NULL);
        devlink_free(devlink);
 
        return err;
@@ -1427,7 +1426,6 @@ static void remove_one(struct pci_dev *pdev)
 #ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING
        cleanup_srcu_struct(&priv->pfault_srcu);
 #endif
-       pci_set_drvdata(pdev, NULL);
        devlink_free(devlink);
 }