drm/panel: s6e8aa0: Update calls to gpiod_get*()
authorAlexandre Courbot <acourbot@nvidia.com>
Thu, 23 Oct 2014 08:16:57 +0000 (17:16 +0900)
committerThierry Reding <treding@nvidia.com>
Thu, 6 Nov 2014 08:50:38 +0000 (09:50 +0100)
Add the new flags argument to calls of (devm_)gpiod_get*() and remove
any direction setting code afterwards.

Currently both forms (with or without the flags argument) are valid
thanks to transitional macros in <linux/gpio/consumer.h>. These macros
will be removed once all consumers are updated and the flags argument
will become compulsary.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/panel/panel-s6e8aa0.c

index b5217fe37f02742e87df986280fb69c2097bead9..6427aa187735291ef8998f8bbd1b5409d4a2752c 100644 (file)
@@ -1019,17 +1019,12 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi)
                return ret;
        }
 
-       ctx->reset_gpio = devm_gpiod_get(dev, "reset");
+       ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
        if (IS_ERR(ctx->reset_gpio)) {
                dev_err(dev, "cannot get reset-gpios %ld\n",
                        PTR_ERR(ctx->reset_gpio));
                return PTR_ERR(ctx->reset_gpio);
        }
-       ret = gpiod_direction_output(ctx->reset_gpio, 1);
-       if (ret < 0) {
-               dev_err(dev, "cannot configure reset-gpios %d\n", ret);
-               return ret;
-       }
 
        ctx->brightness = GAMMA_LEVEL_NUM - 1;