staging: android: ion_test: fix check of platform_device_register_simple() error...

commit ccbc2a9e7878ff09bcaed4893c2a2d3adbb797e2 upstream.

On error platform_device_register_simple() returns ERR_PTR() value,
check for NULL always fails. The change corrects the check itself and
propagates the returned error upwards.

Fixes: 81fb0b901397 ("staging: android: ion_test: unregister the platform device")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c
index b8dcf5a26cc4ac1250bda0ded24d1ceff3c8cf24..58d46893e5ffdec7256bdae2e553560a7209e7c5 100644 (file)
--- a/drivers/staging/android/ion/ion_test.c
+++ b/drivers/staging/android/ion/ion_test.c
@@ -285,8 +285,8 @@ static int __init ion_test_init(void)
 {
        ion_test_pdev = platform_device_register_simple("ion-test",
                                                        -1, NULL, 0);
-       if (!ion_test_pdev)
-               return -ENODEV;
+       if (IS_ERR(ion_test_pdev))
+               return PTR_ERR(ion_test_pdev);
 
        return platform_driver_probe(&ion_test_platform_driver, ion_test_probe);
 }