mfd: kzalloc doesn't return ERR_PTR
authorJulia Lawall <julia@diku.dk>
Fri, 28 May 2010 20:58:46 +0000 (22:58 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 12 Aug 2010 09:27:19 +0000 (11:27 +0200)
Use !x rather than IS_ERR(x) to test the result of kzalloc.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,E;
@@

x = \(kmalloc\|kzalloc\|kcalloc\)(...)
... when != x = E
- IS_ERR(x)
+ !x
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/abx500-core.c

index 3b3b97ec32a764936ca1a8123287cb3c01397752..f12720dbe1262a5a78ce99154c0ca8549552c448 100644 (file)
@@ -36,7 +36,7 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops)
        struct abx500_device_entry *dev_entry;
 
        dev_entry = kzalloc(sizeof(struct abx500_device_entry), GFP_KERNEL);
-       if (IS_ERR(dev_entry)) {
+       if (!dev_entry) {
                dev_err(dev, "register_ops kzalloc failed");
                return -ENOMEM;
        }