drm/i915: Wrap drm_gem_object_reference in i915_gem_object_get
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 20 Jul 2016 12:31:52 +0000 (13:31 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 20 Jul 2016 12:40:11 +0000 (13:40 +0100)
Ultimately wraps kref_get(), so adopt its nomenclature for consistency
with other subsystems.

s/drm_gem_object_reference/i915_gem_object_get/

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/1469005202-9659-5-git-send-email-chris@chris-wilson.co.uk
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1469017917-15134-4-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_gem.c
drivers/gpu/drm/i915/i915_gem_dmabuf.c
drivers/gpu/drm/i915/i915_gem_evict.c
drivers/gpu/drm/i915/i915_gem_execbuffer.c
drivers/gpu/drm/i915/i915_gem_shrinker.c
drivers/gpu/drm/i915/i915_gem_userptr.c
drivers/gpu/drm/i915/intel_display.c

index 47f244f9c64e037842286e82123cee3e452e3ad3..163d28e8e92c11122b2f427f08febb6de8ddc969 100644 (file)
@@ -2306,6 +2306,17 @@ __deprecated
 extern struct drm_gem_object *
 drm_gem_object_lookup(struct drm_file *file, u32 handle);
 
+__attribute__((nonnull))
+static inline struct drm_i915_gem_object *
+i915_gem_object_get(struct drm_i915_gem_object *obj)
+{
+       drm_gem_object_reference(&obj->base);
+       return obj;
+}
+
+__deprecated
+extern void drm_gem_object_reference(struct drm_gem_object *);
+
 static inline bool
 i915_gem_object_has_struct_page(const struct drm_i915_gem_object *obj)
 {
index 970496419098962c98efb24595e6750ff09fda8e..f886c0bb24ca62b06dfd3653aece9b7ed7e6670d 100644 (file)
@@ -289,7 +289,7 @@ drop_pages(struct drm_i915_gem_object *obj)
        struct i915_vma *vma, *next;
        int ret;
 
-       drm_gem_object_reference(&obj->base);
+       i915_gem_object_get(obj);
        list_for_each_entry_safe(vma, next, &obj->vma_list, obj_link)
                if (i915_vma_unbind(vma))
                        break;
@@ -2361,7 +2361,7 @@ void i915_vma_move_to_active(struct i915_vma *vma,
 
        /* Add a reference if we're newly entering the active list. */
        if (obj->active == 0)
-               drm_gem_object_reference(&obj->base);
+               i915_gem_object_get(obj);
        obj->active |= intel_engine_flag(engine);
 
        list_move_tail(&obj->engine_list[engine->id], &engine->active_list);
index 7d08ac08c401261b5d603950a9f0d08e96e54118..3a00ab3ad06e54f37a79d8a95b1bb3244042f541 100644 (file)
@@ -278,8 +278,7 @@ struct drm_gem_object *i915_gem_prime_import(struct drm_device *dev,
                         * Importing dmabuf exported from out own gem increases
                         * refcount on gem itself instead of f_count of dmabuf.
                         */
-                       drm_gem_object_reference(&obj->base);
-                       return &obj->base;
+                       return &i915_gem_object_get(obj)->base;
                }
        }
 
index b1194c7c0a489bef6505b48afb6744697587cb18..56103948ee167e2885678f5587917ea448c3b619 100644 (file)
@@ -183,7 +183,7 @@ found:
                                       exec_list);
                if (drm_mm_scan_remove_block(&vma->node)) {
                        list_move(&vma->exec_list, &eviction_list);
-                       drm_gem_object_reference(&vma->obj->base);
+                       i915_gem_object_get(vma->obj);
                        continue;
                }
                list_del_init(&vma->exec_list);
index 551dd4f549fa4034c06c55cf5c36b8848a761940..28bcc99a0cc19664df4131c79f46bd5e4513de54 100644 (file)
@@ -123,7 +123,7 @@ eb_lookup_vmas(struct eb_vmas *eb,
                        goto err;
                }
 
-               drm_gem_object_reference(&obj->base);
+               i915_gem_object_get(obj);
                list_add_tail(&obj->obj_exec_link, &objects);
        }
        spin_unlock(&file->table_lock);
@@ -1236,7 +1236,7 @@ i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
        vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
        vma->exec_entry = shadow_exec_entry;
        vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
-       drm_gem_object_reference(&shadow_batch_obj->base);
+       i915_gem_object_get(shadow_batch_obj);
        list_add_tail(&vma->exec_list, &eb->vmas);
 
        shadow_batch_obj->base.pending_read_domains = I915_GEM_DOMAIN_COMMAND;
index 6f10b421487b843cc03f0defe666c06ef060fe81..3aa76d3608ea08e9a9352649f0c958e843dd2233 100644 (file)
@@ -190,7 +190,7 @@ i915_gem_shrink(struct drm_i915_private *dev_priv,
                        if (!can_release_pages(obj))
                                continue;
 
-                       drm_gem_object_reference(&obj->base);
+                       i915_gem_object_get(obj);
 
                        /* For the unbound phase, this should be a no-op! */
                        list_for_each_entry_safe(vma, v,
index ba16e044fac677eac0122659b97078d76d68aa2d..c41bf74f926e62d43d441344cc141408d8e634af 100644 (file)
@@ -622,8 +622,7 @@ __i915_gem_userptr_get_pages_schedule(struct drm_i915_gem_object *obj,
        obj->userptr.work = &work->work;
        obj->userptr.workers++;
 
-       work->obj = obj;
-       drm_gem_object_reference(&obj->base);
+       work->obj = i915_gem_object_get(obj);
 
        work->task = current;
        get_task_struct(work->task);
index 77d320584478b23110aafeeaa672ceccd08d42c4..84904a2d3fcd8f67d0ddc67c73eff95aa7e7bae5 100644 (file)
@@ -11649,7 +11649,6 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
 
        /* Reference the objects for the scheduled work. */
        drm_framebuffer_reference(work->old_fb);
-       drm_gem_object_reference(&obj->base);
 
        crtc->primary->fb = fb;
        update_state_fb(crtc->primary);
@@ -11657,7 +11656,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
        intel_fbc_pre_update(intel_crtc, intel_crtc->config,
                             to_intel_plane_state(primary->state));
 
-       work->pending_flip_obj = obj;
+       work->pending_flip_obj = i915_gem_object_get(obj);
 
        ret = i915_mutex_lock_interruptible(dev);
        if (ret)