staging: fsl-mc/dpio: Skip endianness conversion in portal config
authorBogdan Purcareata <bogdan.purcareata@nxp.com>
Thu, 20 Jul 2017 14:48:28 +0000 (14:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 30 Jul 2017 15:25:04 +0000 (08:25 -0700)
Writing to the register using writel does the CPU to LE conversion down the
line, so it's not required here. Doing it breaks portal configuration on
big endian kernels.

Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/bus/dpio/qbman-portal.c

index 7988612aaecf324ca0274502806e32abc3421c00..163bdac6b05116ae4a0a297d80bfc1665992d92a 100644 (file)
@@ -136,18 +136,18 @@ static inline u32 qbman_set_swp_cfg(u8 max_fill, u8 wn,   u8 est, u8 rpm, u8 dcm,
                                    u8 epm, int sd, int sp, int se,
                                    int dp, int de, int ep)
 {
-       return cpu_to_le32 (max_fill << SWP_CFG_DQRR_MF_SHIFT |
-                           est << SWP_CFG_EST_SHIFT |
-                           wn << SWP_CFG_WN_SHIFT |
-                           rpm << SWP_CFG_RPM_SHIFT |
-                           dcm << SWP_CFG_DCM_SHIFT |
-                           epm << SWP_CFG_EPM_SHIFT |
-                           sd << SWP_CFG_SD_SHIFT |
-                           sp << SWP_CFG_SP_SHIFT |
-                           se << SWP_CFG_SE_SHIFT |
-                           dp << SWP_CFG_DP_SHIFT |
-                           de << SWP_CFG_DE_SHIFT |
-                           ep << SWP_CFG_EP_SHIFT);
+       return (max_fill << SWP_CFG_DQRR_MF_SHIFT |
+               est << SWP_CFG_EST_SHIFT |
+               wn << SWP_CFG_WN_SHIFT |
+               rpm << SWP_CFG_RPM_SHIFT |
+               dcm << SWP_CFG_DCM_SHIFT |
+               epm << SWP_CFG_EPM_SHIFT |
+               sd << SWP_CFG_SD_SHIFT |
+               sp << SWP_CFG_SP_SHIFT |
+               se << SWP_CFG_SE_SHIFT |
+               dp << SWP_CFG_DP_SHIFT |
+               de << SWP_CFG_DE_SHIFT |
+               ep << SWP_CFG_EP_SHIFT);
 }
 
 /**