hwmon: (gpio-fan) Prevent overflow problem when writing large limits
authorAxel Lin <axel.lin@ingics.com>
Sat, 2 Aug 2014 05:36:38 +0000 (13:36 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 4 Aug 2014 14:27:50 +0000 (07:27 -0700)
On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value
larger than MAXINT will result in unpredictable limit values written to the
chip. Avoid auto-conversion from unsigned long to int to fix the problem.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/gpio-fan.c

index a43e5b004eb8ddada1054975b0c4310eb9607f4a..4efa1734bdad8d60de7f359dd4e885fc44181c24 100644 (file)
@@ -173,7 +173,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data)
        return -ENODEV;
 }
 
-static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm)
+static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm)
 {
        struct gpio_fan_speed *speed = fan_data->speed;
        int i;