greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 17 Oct 2016 16:37:20 +0000 (16:37 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2016 13:51:00 +0000 (15:51 +0200)
This node pointer is returned by of_find_compatible_node() with
refcount incremented in this function. of_node_put() on it before
exitting this function.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/arche-platform.c

index e36ee984485bfcf3aea56f777e9f7ec4c671ed02..34307ac3f2558b1e30794bd77c7c2b85ae4839e3 100644 (file)
@@ -128,6 +128,7 @@ int arche_platform_change_state(enum arche_platform_state state,
        pdev = of_find_device_by_node(np);
        if (!pdev) {
                pr_err("arche-platform device not found\n");
+               of_node_put(np);
                return -ENODEV;
        }