xfs: fold __xfs_trans_roll into xfs_trans_roll
authorChristoph Hellwig <hch@lst.de>
Thu, 6 Apr 2017 23:00:11 +0000 (16:00 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 6 Apr 2017 23:00:11 +0000 (16:00 -0700)
No one cares about the low-level helper anymore.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_trans.c
fs/xfs/xfs_trans.h

index a280e126491fd631584630991805ad9f9ba50e49..be86e4ed23d5ddd442fc7e576fe86715c5f91852 100644 (file)
@@ -1034,17 +1034,14 @@ xfs_trans_cancel(
  * chunk we've been working on and get a new transaction to continue.
  */
 int
-__xfs_trans_roll(
+xfs_trans_roll(
        struct xfs_trans        **tpp,
-       struct xfs_inode        *dp,
-       int                     *committed)
+       struct xfs_inode        *dp)
 {
        struct xfs_trans        *trans;
        struct xfs_trans_res    tres;
        int                     error;
 
-       *committed = 0;
-
        /*
         * Ensure that the inode is always logged.
         */
@@ -1070,7 +1067,6 @@ __xfs_trans_roll(
        if (error)
                return error;
 
-       *committed = 1;
        trans = *tpp;
 
        /*
@@ -1093,12 +1089,3 @@ __xfs_trans_roll(
                xfs_trans_ijoin(trans, dp, 0);
        return 0;
 }
-
-int
-xfs_trans_roll(
-       struct xfs_trans        **tpp,
-       struct xfs_inode        *dp)
-{
-       int                     committed;
-       return __xfs_trans_roll(tpp, dp, &committed);
-}
index 2a9292df6640f5d1be1d106b65ce19e3c1858410..a07acbf0bd8a4f491fc4976b31dfcc696e7a5b18 100644 (file)
@@ -228,7 +228,6 @@ int         xfs_trans_free_extent(struct xfs_trans *,
                                      struct xfs_efd_log_item *, xfs_fsblock_t,
                                      xfs_extlen_t, struct xfs_owner_info *);
 int            xfs_trans_commit(struct xfs_trans *);
-int            __xfs_trans_roll(struct xfs_trans **, struct xfs_inode *, int *);
 int            xfs_trans_roll(struct xfs_trans **, struct xfs_inode *);
 void           xfs_trans_cancel(xfs_trans_t *);
 int            xfs_trans_ail_init(struct xfs_mount *);