Use `Helper::isAjaxRequest()`
authorTim Düsterhus <duesterhus@woltlab.com>
Mon, 8 Aug 2022 09:39:25 +0000 (11:39 +0200)
committerTim Düsterhus <duesterhus@woltlab.com>
Mon, 8 Aug 2022 09:39:25 +0000 (11:39 +0200)
wcfsetup/install/files/lib/http/middleware/CheckForOfflineMode.class.php
wcfsetup/install/files/lib/http/middleware/CheckUserBan.class.php

index 47ef9608913de1b2ba5f91c15a901917a67303bf..9953ef652d4bacad57ffa890235066e5e45049af 100644 (file)
@@ -7,6 +7,7 @@ use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\MiddlewareInterface;
 use Psr\Http\Server\RequestHandlerInterface;
+use wcf\http\Helper;
 use wcf\system\box\BoxHandler;
 use wcf\system\exception\AJAXException;
 use wcf\system\notice\NoticeHandler;
@@ -47,7 +48,7 @@ final class CheckForOfflineMode implements MiddlewareInterface
 
     private function getOfflineResponse(ServerRequestInterface $request): ResponseInterface
     {
-        if ($this->isAjaxRequest($request)) {
+        if (Helper::isAjaxRequest($request)) {
             throw new AJAXException(
                 WCF::getLanguage()->getDynamicVariable('wcf.ajax.error.permissionDenied'),
                 AJAXException::INSUFFICIENT_PERMISSIONS
@@ -79,9 +80,4 @@ final class CheckForOfflineMode implements MiddlewareInterface
     {
         return WCF::getSession()->getPermission('admin.general.canViewPageDuringOfflineMode');
     }
-
-    private function isAjaxRequest(ServerRequestInterface $request): bool
-    {
-        return $request->getHeaderLine('x-requested-with') === 'XMLHttpRequest';
-    }
 }
index 3b3ed410bc551f0ec1fcec76748f5d2011addfe1..82645b304b2613c2c849b2a3c5f4cfa3e12c1677 100644 (file)
@@ -7,6 +7,7 @@ use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\MiddlewareInterface;
 use Psr\Http\Server\RequestHandlerInterface;
 use wcf\data\user\User;
+use wcf\http\Helper;
 use wcf\system\exception\AJAXException;
 use wcf\system\exception\NamedUserException;
 use wcf\system\WCF;
@@ -30,7 +31,7 @@ final class CheckUserBan implements MiddlewareInterface
         $user = WCF::getUser();
 
         if ($this->isBanned($user)) {
-            if ($this->isAjaxRequest($request)) {
+            if (Helper::isAjaxRequest($request)) {
                 throw new AJAXException(
                     WCF::getLanguage()->getDynamicVariable('wcf.user.error.isBanned'),
                     AJAXException::INSUFFICIENT_PERMISSIONS
@@ -59,9 +60,4 @@ final class CheckUserBan implements MiddlewareInterface
 
         return !!$user->banned;
     }
-
-    private function isAjaxRequest(ServerRequestInterface $request): bool
-    {
-        return $request->getHeaderLine('x-requested-with') === 'XMLHttpRequest';
-    }
 }