arm64: Clear out any singlestep state on a ptrace detach operation
authorJohn Blackwood <john.blackwood@ccur.com>
Mon, 7 Dec 2015 11:50:34 +0000 (11:50 +0000)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:11:16 +0000 (13:11 +0000)
commit 5db4fd8c52810bd9740c1240ebf89223b171aa70 upstream.

Make sure to clear out any ptrace singlestep state when a ptrace(2)
PTRACE_DETACH call is made on arm64 systems.

Otherwise, the previously ptraced task will die off with a SIGTRAP
signal if the debugger just previously singlestepped the ptraced task.

Signed-off-by: John Blackwood <john.blackwood@ccur.com>
[will: added comment to justify why this is in the arch code]
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/kernel/ptrace.c

index 0fb13542e9d66f87a8d2d4d29cda3933e7c98ce5..ce591f3e02c17a44e6aa0a72cdfd5047123a8b16 100644 (file)
  */
 void ptrace_disable(struct task_struct *child)
 {
+       /*
+        * This would be better off in core code, but PTRACE_DETACH has
+        * grown its fair share of arch-specific worts and changing it
+        * is likely to cause regressions on obscure architectures.
+        */
+       user_disable_single_step(child);
 }
 
 #ifdef CONFIG_HAVE_HW_BREAKPOINT