Staging: octeon: Add missing of_node_put after calling of_parse_phandle.
authorSandhya Bankar <bankarsandhya512@gmail.com>
Sun, 18 Sep 2016 17:32:33 +0000 (23:02 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Sep 2016 11:51:24 +0000 (13:51 +0200)
of_node_put needs to be called when the device node which is got
from of_parse_phandle is no longer used.
This patch is found by below coccinelle script:

@@
expression e,e1,e2;
@@
*e = of_parse_phandle(...)
... when != of_node_put(e)
    when != true e == NULL
    when != e2 = e
e = e1

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/octeon/ethernet-mdio.c

index 1fde9c824948c6f296fb2e099e314b0ea73d7f13..691e4a51ace43197766e55f9aca471918270b2ec 100644 (file)
@@ -168,6 +168,7 @@ int cvm_oct_phy_setup_device(struct net_device *dev)
 
        phydev = of_phy_connect(dev, phy_node, cvm_oct_adjust_link, 0,
                                PHY_INTERFACE_MODE_GMII);
+       of_node_put(phy_node);
 
        if (!phydev)
                return -ENODEV;