veth: Fix veth_dellink method
authorEric Dumazet <eric.dumazet@gmail.com>
Fri, 30 Oct 2009 08:00:27 +0000 (01:00 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Oct 2009 08:00:27 +0000 (01:00 -0700)
In commit 23289a37e2b127dfc4de1313fba15bb4c9f0cd5b
(net: add a list_head parameter to dellink() method),
I forgot to actually use this parameter in veth_dellink.

I remember feeling a bit uncomfortable about veth_close(),
because it does :

netif_carrier_off(dev);
netif_carrier_off(priv->peer);

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/veth.c

index ffb502daa91655096398a950b2e184c8f3a82a15..9bed694cd215a4d644952978e20172ae3bdc8175 100644 (file)
@@ -450,8 +450,8 @@ static void veth_dellink(struct net_device *dev, struct list_head *head)
        priv = netdev_priv(dev);
        peer = priv->peer;
 
-       unregister_netdevice(dev);
-       unregister_netdevice(peer);
+       unregister_netdevice_queue(dev, head);
+       unregister_netdevice_queue(peer, head);
 }
 
 static const struct nla_policy veth_policy[VETH_INFO_MAX + 1];