drm/i915: fully switch off overlay when not in use
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 15 Sep 2009 20:57:35 +0000 (22:57 +0200)
committerEric Anholt <eric@anholt.net>
Thu, 5 Nov 2009 22:47:08 +0000 (14:47 -0800)
Now that the cache flushing of the memory based overlay regs works,
we can safely switch off the overlay. Beforehand it was only disabled
(like in userspace).

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Eric Anholt <eric@anholt.net>
drivers/gpu/drm/i915/intel_overlay.c

index 3f6f3a36929f774c48a6858f185ed67aa0110b43..4e88abb423b084111ff46020f73af555266ca222 100644 (file)
@@ -323,7 +323,6 @@ static int intel_overlay_off(struct intel_overlay *overlay)
        }
 
        /* turn overlay off */
-       /* this is not done in userspace!
        BEGIN_LP_RING(6);
         OUT_RING(MI_FLUSH);
         OUT_RING(MI_NOOP);
@@ -338,7 +337,7 @@ static int intel_overlay_off(struct intel_overlay *overlay)
                DRM_ERROR("intel overlay: ring sync failed, hw likely wedged\n");
                overlay->hw_wedged = 1;
                return ret;
-       }*/
+       }
 
        overlay->active = 0;