[SCSI] iscsi_transport: Check iscsi interface skb allocation return value

Let's not oops when we cannot allocate a skb! Add a check
for if alloc_skb fails.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index caf1836bbeca7506c15431d582965892666a4e6d..4fbd8e1a06959213b853069962db991f4df22b95 100644 (file)
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -609,12 +609,10 @@ iscsi_if_send_reply(int pid, int seq, int type, int done, int multi,
        int t = done ? NLMSG_DONE : type;
 
        skb = alloc_skb(len, GFP_ATOMIC);
-       /*
-        * FIXME:
-        * user is supposed to react on iferror == -ENOMEM;
-        * see iscsi_if_rx().
-        */
-       BUG_ON(!skb);
+       if (!skb) {
+               printk(KERN_ERR "Could not allocate skb to send reply.\n");
+               return -ENOMEM;
+       }
 
        nlh = __nlmsg_put(skb, pid, seq, t, (len - sizeof(*nlh)), 0);
        nlh->nlmsg_flags = flags;