usb: gadget: omap_udc: kfree(NULL) is safe
authorFelipe Balbi <balbi@ti.com>
Tue, 29 May 2012 11:38:32 +0000 (14:38 +0300)
committerFelipe Balbi <balbi@ti.com>
Sun, 3 Jun 2012 20:11:34 +0000 (23:11 +0300)
we don't need to check for _req because
kfree(NULL) is safe. Also, if someone
actually passes a NULL pointer to be freed
by usb_ep_free_request(), he deserves any
issue he faces.

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/omap_udc.c

index f13bcdc756760eedd38c346bb85614b059a3938c..50e8490867ed7a077dc8bea7a091f046beddef0b 100644 (file)
@@ -282,8 +282,7 @@ omap_free_request(struct usb_ep *ep, struct usb_request *_req)
 {
        struct omap_req *req = container_of(_req, struct omap_req, req);
 
-       if (_req)
-               kfree(req);
+       kfree(req);
 }
 
 /*-------------------------------------------------------------------------*/