ath5k: remove monitor check in receive_frame_ok filter
authorBob Copeland <me@bobcopeland.com>
Sun, 15 Aug 2010 17:03:13 +0000 (13:03 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 24 Aug 2010 20:28:01 +0000 (16:28 -0400)
Monitor interfaces are never seen by the driver, so tests based on
that opmode don't make sense.  Also, we already pass all mic
failure packets.

Consequently this code is actually accepting any frames with just
crypto errors and rejecting those with CRC, FIFO, and PHY errors for
all interface types.  Adjust the code and comment accordingly.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath5k/base.c

index c3b614d2ef34ae6729d5be48c4b3c6f7a034083e..166029913884b1357cb4944fc884f418840f141a 100644 (file)
@@ -2035,9 +2035,8 @@ ath5k_receive_frame_ok(struct ath5k_softc *sc, struct ath5k_rx_status *rs)
                        return true;
                }
 
-               /* let crypto-error packets fall through in MNTR */
-               if ((rs->rs_status & ~(AR5K_RXERR_DECRYPT|AR5K_RXERR_MIC)) ||
-                   sc->opmode != NL80211_IFTYPE_MONITOR)
+               /* reject any frames with non-crypto errors */
+               if (rs->rs_status & ~(AR5K_RXERR_DECRYPT))
                        return false;
        }