rxrpc: Be consistent about switch value in rxrpc_send_call_packet()
authorDavid Howells <dhowells@redhat.com>
Sat, 17 Sep 2016 09:49:12 +0000 (10:49 +0100)
committerDavid Howells <dhowells@redhat.com>
Sat, 17 Sep 2016 09:54:21 +0000 (10:54 +0100)
rxrpc_send_call_packet() should use type in both its switch-statements
rather than using pkt->whdr.type.  This might give the compiler an easier
job of uninitialised variable checking.

Signed-off-by: David Howells <dhowells@redhat.com>
net/rxrpc/output.c

index aa0507214b3123bffe6ed13fb071a767f0f22099..0b21ed859de7c71a9b829afd9fd5b640dc7960e9 100644 (file)
@@ -182,7 +182,7 @@ int rxrpc_send_call_packet(struct rxrpc_call *call, u8 type)
                             &msg, iov, ioc, len);
 
        if (ret < 0 && call->state < RXRPC_CALL_COMPLETE) {
-               switch (pkt->whdr.type) {
+               switch (type) {
                case RXRPC_PACKET_TYPE_ACK:
                        rxrpc_propose_ACK(call, pkt->ack.reason,
                                          ntohs(pkt->ack.maxSkew),