[SCSI] mpt2sas: Use compat_ptr to setup the pointer compatibility.
authorKashyap, Desai <kashyap.desai@lsi.com>
Wed, 16 Dec 2009 13:23:04 +0000 (18:53 +0530)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 9 Feb 2010 00:19:40 +0000 (18:19 -0600)
On ppc64, an 32bit application was failing due to data buffers not being
copied properly from user to kernel memory.  The problem due to improper
conversion of 32 to 64 bit pointers.  The fix is to use compat_ptr to
setup the pointer compatibility in the routine _ctl_compat_mpt_command.

Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
Reviewed-by: Eric Moore <eric.moore@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/mpt2sas/mpt2sas_ctl.c

index 198ecdd849a424a6aa88a39188c014b71504621c..fa9bf83819d50cc269f05db3f58f2ed10d86bda0 100644 (file)
@@ -2203,14 +2203,10 @@ _ctl_compat_mpt_command(struct file *file, unsigned cmd, unsigned long arg)
        karg.data_out_size = karg32.data_out_size;
        karg.max_sense_bytes = karg32.max_sense_bytes;
        karg.data_sge_offset = karg32.data_sge_offset;
-       memcpy(&karg.reply_frame_buf_ptr, &karg32.reply_frame_buf_ptr,
-           sizeof(uint32_t));
-       memcpy(&karg.data_in_buf_ptr, &karg32.data_in_buf_ptr,
-           sizeof(uint32_t));
-       memcpy(&karg.data_out_buf_ptr, &karg32.data_out_buf_ptr,
-           sizeof(uint32_t));
-       memcpy(&karg.sense_data_ptr, &karg32.sense_data_ptr,
-           sizeof(uint32_t));
+       karg.reply_frame_buf_ptr = compat_ptr(karg32.reply_frame_buf_ptr);
+       karg.data_in_buf_ptr = compat_ptr(karg32.data_in_buf_ptr);
+       karg.data_out_buf_ptr = compat_ptr(karg32.data_out_buf_ptr);
+       karg.sense_data_ptr = compat_ptr(karg32.sense_data_ptr);
        state = (file->f_flags & O_NONBLOCK) ? NON_BLOCKING : BLOCKING;
        return _ctl_do_mpt_command(ioc, karg, &uarg->mf, state);
 }