drivers: soc: sunxi: fix error processing on base address when claiming
authorIcenowy Zheng <icenowy@aosc.io>
Wed, 9 Aug 2017 08:56:25 +0000 (16:56 +0800)
committerChen-Yu Tsai <wens@csie.org>
Fri, 18 Aug 2017 06:30:19 +0000 (14:30 +0800)
When claiming SRAM, if the base is set to an error, it means that the
SRAM controller has been probed, but failed to remap the controller
memory zone. If the base is zero, thus the SRAM controller should be not
probed at all, and it should return -EPROBE_DEFER. However, currently we
returned -EPROBE_DEFER in the former situation, and ignored the latter
situation (which will lead to the kernel to panic).

Fix the behavior on abnormal base address processing when claiming.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map
      SRAMs")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
drivers/soc/sunxi/sunxi_sram.c

index 99e354c8f53f8cdff0c34c4285a42cef4021565c..c1ff7fa62cb4cf92d3772fe90291c52f8b7fb66a 100644 (file)
@@ -190,6 +190,9 @@ int sunxi_sram_claim(struct device *dev)
        u32 val, mask;
 
        if (IS_ERR(base))
+               return PTR_ERR(base);
+
+       if (!base)
                return -EPROBE_DEFER;
 
        if (!dev || !dev->of_node)