drm/i915: Consolidate DDI clock reading out in a single function
authorDamien Lespiau <damien.lespiau@intel.com>
Fri, 12 Dec 2014 14:26:57 +0000 (14:26 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 15 Dec 2014 14:43:02 +0000 (15:43 +0100)
2 pieces of code need to read out the DDI clock: the DDI encoder and the
MST encoder .get_config() vfuncs.

Until now the SKL read out code was only in the former, so let's move
the pre and post SKL logic in intel_ddi_clock_get() and this this one
everywhere.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_ddi.c

index 4e2e8608b46bb62e601fcd829d56b99c7c72014b..1c92ad47502b0f13956c5a2c2a0349352d250933 100644 (file)
@@ -834,7 +834,12 @@ static void hsw_ddi_clock_get(struct intel_encoder *encoder,
 void intel_ddi_clock_get(struct intel_encoder *encoder,
                         struct intel_crtc_config *pipe_config)
 {
-       hsw_ddi_clock_get(encoder, pipe_config);
+       struct drm_device *dev = encoder->base.dev;
+
+       if (INTEL_INFO(dev)->gen <= 8)
+               hsw_ddi_clock_get(encoder, pipe_config);
+       else
+               skl_ddi_clock_get(encoder, pipe_config);
 }
 
 static void
@@ -2029,7 +2034,6 @@ void intel_ddi_get_config(struct intel_encoder *encoder,
        enum transcoder cpu_transcoder = intel_crtc->config.cpu_transcoder;
        struct intel_hdmi *intel_hdmi;
        u32 temp, flags = 0;
-       struct drm_device *dev = dev_priv->dev;
 
        temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
        if (temp & TRANS_DDI_PHSYNC)
@@ -2106,10 +2110,7 @@ void intel_ddi_get_config(struct intel_encoder *encoder,
                dev_priv->vbt.edp_bpp = pipe_config->pipe_bpp;
        }
 
-       if (INTEL_INFO(dev)->gen <= 8)
-               hsw_ddi_clock_get(encoder, pipe_config);
-       else
-               skl_ddi_clock_get(encoder, pipe_config);
+       intel_ddi_clock_get(encoder, pipe_config);
 }
 
 static void intel_ddi_destroy(struct drm_encoder *encoder)