nfsd: fix NULL pointer dereference in cld_pipe_downcall

If we find that "cup" is NULL in this case, then we obviously don't
want to dereference it. What we really want to print in this case
is the xid that we copied off earlier.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 21b53d57432cfdcab5545df6d56a494403450cd5..eaaf9482c7f5cd2828b08d2dceb742668c56ed59 100644 (file)
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -602,8 +602,7 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
 
        /* couldn't find upcall? */
        if (!cup) {
-               dprintk("%s: couldn't find upcall -- xid=%u\n", __func__,
-                       cup->cu_msg.cm_xid);
+               dprintk("%s: couldn't find upcall -- xid=%u\n", __func__, xid);
                return -EINVAL;
        }