regmap: Share some of the debugfs infrastructure ready for more files
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 10 Aug 2011 08:15:31 +0000 (17:15 +0900)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Sun, 14 Aug 2011 10:51:14 +0000 (19:51 +0900)
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/base/regmap/regmap-debugfs.c

index fff8e832a985ff3963cebdda175c8277ceb759ff..e541d7f4b4e07b5558de9edb89e555860f81a7c2 100644 (file)
 
 static struct dentry *regmap_debugfs_root;
 
-static int regmap_map_open_file(struct inode *inode, struct file *file)
+/* Calculate the length of a fixed format  */
+static size_t regmap_calc_reg_len(int max_val, char *buf, size_t buf_size)
+{
+       snprintf(buf, buf_size, "%x", max_val);
+       return strlen(buf);
+}
+
+static int regmap_open_file(struct inode *inode, struct file *file)
 {
        file->private_data = inode->i_private;
        return 0;
@@ -46,8 +53,7 @@ static ssize_t regmap_map_read_file(struct file *file, char __user *user_buf,
                return -ENOMEM;
 
        /* Calculate the length of a fixed format  */
-       snprintf(buf, count, "%x", map->max_register);
-       reg_len = strlen(buf);
+       reg_len = regmap_calc_reg_len(map->max_register, buf, count);
        val_len = 2 * map->format.val_bytes;
        tot_len = reg_len + val_len + 3;      /* : \n */
 
@@ -98,7 +104,7 @@ out:
 }
 
 static const struct file_operations regmap_map_fops = {
-       .open = regmap_map_open_file,
+       .open = regmap_open_file,
        .read = regmap_map_read_file,
        .llseek = default_llseek,
 };