atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()
authorTillmann Heidsieck <theidsieck@leenox.de>
Sat, 10 Oct 2015 19:47:18 +0000 (21:47 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Oct 2015 02:56:26 +0000 (19:56 -0700)
Smatch complains about returning hard coded error codes, silence this
warning.

drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Tillmann Heidsieck <theidsieck@leenox.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/iphase.c

index 65e65903faa072f5d9f8897bf9052112ad624866..d5010d7a99c34335c9a6a2f0cb171e24f54e67b5 100644 (file)
@@ -112,7 +112,8 @@ static void ia_enque_head_rtn_q (IARTN_Q *que, IARTN_Q * data)
 
 static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
    IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
-   if (!entry) return -1;
+   if (!entry)
+      return -ENOMEM;
    entry->data = data;
    entry->next = NULL;
    if (que->next == NULL)