net/macb: Factor out one-time assignment from loop
authorBen Shelton <ben.shelton@ni.com>
Wed, 22 Apr 2015 22:28:54 +0000 (17:28 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Apr 2015 22:34:56 +0000 (18:34 -0400)
In 02c958dd3 (net/macb: add TX multiqueue support for gem), the
initialization of tx_head and tx_tail in macb_init_rings() was moved
inside the loop that iterates over each element in the ring.  Since
tx_head and tx_tail only need to be assigned once, move them back out of
the loop.

Signed-off-by: Ben Shelton <ben.shelton@ni.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb.c

index 9f5387249f242374437581e6c2df7c037917f83a..665c29098e3c27306e8a276bf2aafc38a5b0f3db 100644 (file)
@@ -1473,9 +1473,9 @@ static void macb_init_rings(struct macb *bp)
        for (i = 0; i < TX_RING_SIZE; i++) {
                bp->queues[0].tx_ring[i].addr = 0;
                bp->queues[0].tx_ring[i].ctrl = MACB_BIT(TX_USED);
-               bp->queues[0].tx_head = 0;
-               bp->queues[0].tx_tail = 0;
        }
+       bp->queues[0].tx_head = 0;
+       bp->queues[0].tx_tail = 0;
        bp->queues[0].tx_ring[TX_RING_SIZE - 1].ctrl |= MACB_BIT(TX_WRAP);
 
        bp->rx_tail = 0;