brcm80211: Delete an unnecessary check before the function call "release_firmware"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 6 Nov 2015 07:48:23 +0000 (08:48 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 26 Nov 2015 12:03:19 +0000 (14:03 +0200)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c

index 4248f3c80e78e10016805cf4caed296b801935e2..33afb9aafa9ba57506953ccfce7ab3dd76ff8d8f 100644 (file)
@@ -449,8 +449,7 @@ static void brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx)
 
        if (raw_nvram)
                bcm47xx_nvram_release_contents(data);
-       if (fw)
-               release_firmware(fw);
+       release_firmware(fw);
        if (!nvram && !(fwctx->flags & BRCMF_FW_REQ_NV_OPTIONAL))
                goto fail;