It strikes me as strange to add one to a value while checking to see
if it exceeds a maximum.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
int string_size;
struct gmod_string *gmod_string;
- if ((gmod->num_strings + 1) >= MAX_STRINGS_PER_MODULE) {
+ if (gmod->num_strings == MAX_STRINGS_PER_MODULE) {
dev_err(gmod->dev.parent,
"too many strings for this module!\n");
return -EINVAL;
{
struct gmod_cport *gmod_cport;
- if ((gmod->num_cports + 1) >= MAX_CPORTS_PER_MODULE) {
+ if (gmod->num_cports == MAX_CPORTS_PER_MODULE) {
dev_err(gmod->dev.parent, "too many cports for this module!\n");
return -EINVAL;
}