e1000e: Fix EEE in S5 w/ Runtime PM enabled
authorDavid Ertman <david.m.ertman@intel.com>
Fri, 11 Jul 2014 06:21:23 +0000 (06:21 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sat, 26 Jul 2014 04:08:12 +0000 (21:08 -0700)
The process of shutting down the system causes a call to the close PM
callback.  The reset in close causes a loss of link, and the resultant
LSC interrupt causes the Runtime PM idle callback to be called.  The
check for link (while link is down) in the idle callback is wiping the
information about the EEE ability of the link partner.  The information is
still gone when the PHY is powered back up in the shutdown flow.  This
causes EEE in S5 to fail when Runtime PM is active.

Save the link partner's EEE ability in the idle callback so that a Runtime
PM event will not cause a loss of this information.

Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/netdev.c

index fe3e42a6c8e994b37286a21a9cda1208a2dd07b8..1ce0d743029ce6048e35d06462cf8c26b91b255f 100644 (file)
@@ -6357,9 +6357,14 @@ static int e1000e_pm_runtime_idle(struct device *dev)
        struct pci_dev *pdev = to_pci_dev(dev);
        struct net_device *netdev = pci_get_drvdata(pdev);
        struct e1000_adapter *adapter = netdev_priv(netdev);
+       u16 eee_lp;
 
-       if (!e1000e_has_link(adapter))
+       eee_lp = adapter->hw.dev_spec.ich8lan.eee_lp_ability;
+
+       if (!e1000e_has_link(adapter)) {
+               adapter->hw.dev_spec.ich8lan.eee_lp_ability = eee_lp;
                pm_schedule_suspend(dev, 5 * MSEC_PER_SEC);
+       }
 
        return -EBUSY;
 }